adriancarriger / angularfire2-offline

🔌 A simple wrapper for AngularFire2 to read and write to Firebase while offline, even after a complete refresh.
https://angularfire2-offline.firebaseapp.com/
MIT License
207 stars 48 forks source link

Cannot find module 'angularfire2/interfaces' #62

Closed netomarchiori closed 7 years ago

netomarchiori commented 7 years ago

Hello, when i try to run the "ionic" example, i get:

typescript: node_modules/angularfire2-offline/database/database.d.ts, line: 2
Cannot find module 'angularfire2/interfaces'.

L2:  import { FirebaseListFactoryOpts, FirebaseObjectFactoryOpts } from 'angularfire2/interfaces';

For some reason, FirebaseListFactoryOpts is located at 'angularfire2/database/interfaces' not on 'angular/interfaces'

Im using: angularfire2@4.0.0-rc.2 angularfire2-offline@4.1.1

I manage to fix the code by correcting the imports, however i don't know how to do a pull request

adriancarriger commented 7 years ago

Hi @netomarchiori, thanks for posting!

I was able to reproduce the issue and have updated the example to avoid the error. It looks like angularfire2 at version 4.0.0-rc.2 resulted in type erros but version 4.0.0-rc.0 works weel so I pinned the version.

Steps to test change

Following these steps should now no longer produce the type errors you mentioned:

Let me know if you have any questions. Thanks! 👍

netomarchiori commented 7 years ago

spot on! worked as expected! thanks @adriancarriger