search

adrianco / spigo

Simulate Protocol Interactions in Go
Apache License 2.0
1.12k stars 111 forks source link

Collect and save/process histograms of response times #59

Open adrianco opened 8 years ago

adrianco commented 8 years ago

Tweaked hdrhistogram configuration to use much less memory. Changes to metrics package to export histograms - need to make a pull request for codahale/metrics Collect histograms for response time (zipkin cr-cs) and service time (zipkin ss-sr) as well as network delay (zipkin sr-cs was the initial implementation, cr-ss).

Save time distributions in the json graph when a node exits.

hubayirp commented 8 years ago

nice!

On Sat, Dec 26, 2015 at 9:48 AM, Adrian Cockcroft notifications@github.com wrote:

Tweaked hdrhistogram configuration to use much less memory Changes to metrics package to export histograms - need to make a pull request for codahale/metrics Collect histograms for response time (zipkin cr-cs) and service time (zipkin ss-sr) as well as network delay (zipkin sr-cs was the initial implementation, cr-ss)

Save time distributions in the json graph when a node exits

— Reply to this email directly or view it on GitHub https://github.com/adrianco/spigo/issues/59.

adrianco commented 8 years ago

I'm working with the author of Guesstimate to figure out a way to feed spigo models to it. A hand created example of what that might look like is here: http://getguesstimate.com/models/1307

The project is https://github.com/getguesstimate/guesstimate-app

adrianco commented 8 years ago

Updates made to codahale/hdrhistogram and pull request accepted, so now distributions can be extracted from the histogram.

Switched from codahale/metrics to go-kit/kit/metrics and submitted pull request for extvars to use updated hdrhistogram to save distributions.

Changed flow and collect and denominator, needs some more cleanup before updating github.

hubayirp commented 8 years ago

Even more Go friendly - nice! On Sun, Jan 31, 2016 at 5:29 PM Adrian Cockcroft notifications@github.com wrote:

Updates made to codahale/hdrhistogram and pull request accepted, so now distributions can be extracted from the histogram.

Switched from codahale/metrics to go-kit/kit/metrics and submitted pull request for extvars to use updated hdrhistogram to save distributions.

Changed flow and collect and denominator, needs some more cleanup before updating github.

— Reply to this email directly or view it on GitHub https://github.com/adrianco/spigo/issues/59#issuecomment-177691509.

adrianco commented 8 years ago

Implementation complete and code updated - see collect package. Now uses go-kit/metrics which was updated to allow histograms to be extracted and printed Updates were also made to codahale/hdrhistogram to allow histogram distributions to be exported Interface added to guesstimate (see github.com/adrianco/goguesstimate for implementation) which allows distributions to export a file for upload to getguesstimate.com

hubayirp commented 8 years ago

Nice find!

On Fri, Feb 5, 2016 at 7:25 AM, Adrian Cockcroft notifications@github.com wrote:

Implementation complete and code updated - see collect package. Now uses go-kit/metrics which was updated to allow histograms to be extracted and printed Updates were also made to codahale/hdrhistogram to allow histogram distributions to be exported Interface added to guesstimate (see github.com/adrianco/goguesstimate for implementation) which allows distributions to export a file for upload to getguesstimate.com

— Reply to this email directly or view it on GitHub https://github.com/adrianco/spigo/issues/59#issuecomment-180399978.

hubayirp commented 8 years ago

Beats DataHero!

On Fri, Feb 5, 2016 at 10:09 AM, priya joseph elleayirp@gmail.com wrote:

Nice find!

On Fri, Feb 5, 2016 at 7:25 AM, Adrian Cockcroft <notifications@github.com

wrote:

Implementation complete and code updated - see collect package. Now uses go-kit/metrics which was updated to allow histograms to be extracted and printed Updates were also made to codahale/hdrhistogram to allow histogram distributions to be exported Interface added to guesstimate (see github.com/adrianco/goguesstimate for implementation) which allows distributions to export a file for upload to getguesstimate.com

— Reply to this email directly or view it on GitHub https://github.com/adrianco/spigo/issues/59#issuecomment-180399978.