search

adrianco / spigo

Simulate Protocol Interactions in Go
Apache License 2.0
1.12k stars 111 forks source link

Added ability to flush Zipkin spans to Kafka Exporter #79

Closed basvanbeek closed 7 years ago

basvanbeek commented 8 years ago

If running an actual Kafka backed Zipkin installation this update allows one to send the flow output to Kafka for direct injection into Zipkin using the Kafka collector.

codefromthecrypt commented 8 years ago

nice this looks like a nice interim step towards flowing to kafka during the simulation #67

basvanbeek commented 8 years ago

yes, I didn't want to implement live flowing yet as it would mean more refactoring and adjusting of the current code base. More than happy to build it but would like some comments from @adrianco on expected direction first.

I was thinking making the flow package an interface so we could have different output stream implementations.

adrianco commented 8 years ago

Thanks! I'll take a look over the next few days.