adriangb / di

Pythonic dependency injection
https://www.adriangb.com/di/
MIT License
301 stars 13 forks source link

Feature/add python3.12 drop python3.7 #112

Closed maxzhenzhera closed 1 year ago

maxzhenzhera commented 1 year ago

Closes #111

codecov-commenter commented 1 year ago

Codecov Report

Merging #112 (b49bb51) into main (0e7adb3) will increase coverage by 0.30%. The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   96.93%   97.24%   +0.30%     
==========================================
  Files          67       66       -1     
  Lines        2320     2284      -36     
  Branches      336      327       -9     
==========================================
- Hits         2249     2221      -28     
+ Misses         61       54       -7     
+ Partials       10        9       -1     
Files Coverage Δ
di/_container.py 93.85% <ø> (-0.03%) :arrow_down:
di/_utils/concurrency.py 100.00% <ø> (ø)
di/_utils/inspect.py 100.00% <ø> (ø)
di/_utils/types.py 100.00% <100.00%> (ø)
di/api/dependencies.py 100.00% <100.00%> (ø)
di/api/executor.py 100.00% <100.00%> (ø)
di/typing.py 100.00% <100.00%> (ø)
docs_src/bind_as_a_dep.py 100.00% <100.00%> (ø)
docs_src/solved_dependent.py 100.00% <100.00%> (ø)
tests/docs/test_sharing_example.py 100.00% <ø> (ø)
... and 3 more

... and 2 files with indirect coverage changes

maxzhenzhera commented 1 year ago

Omg, I made smth bad for python3.8 I think it is a question of imports

maxzhenzhera commented 1 year ago

Hmm, I believed that get_origin, get_args had become available in python3.8 and it is safe to use them just from std...)

adriangb commented 1 year ago

Hmm, I believed that get_origin, get_args had become available in python3.8 and it is safe to use them just from std...)

I don't think so: https://github.com/python/typing_extensions/blob/b6318ab4b4777a38b468eef7aae97061c283eb8d/src/typing_extensions.py#L1175-L1177

maxzhenzhera commented 1 year ago

I don't think so: https://github.com/python/typing_extensions/blob/b6318ab4b4777a38b468eef7aae97061c283eb8d/src/typing_extensions.py#L1175-L1177

Okay, I see. Thanks for pointing that out.

maxzhenzhera commented 1 year ago

@adriangb Please, review