search

adriangb / scikeras

Scikit-Learn API wrapper for Keras.
https://www.adriangb.com/scikeras/
MIT License
239 stars 47 forks source link

Remove private access of scikeras._utils.TFRandomState from docs #253

Closed adriangb closed 2 years ago

adriangb commented 2 years ago

See https://github.com/adriangb/scikeras/pull/252#discussion_r746793852

stsievert commented 2 years ago

If tf_random_state is public, it might worthy to implement this test: https://github.com/adriangb/scikeras/pull/252#discussion_r746863916

https://github.com/adriangb/scikeras/blob/67de2388f34eecd1f09d4b1deaeb8ada5c60dc1b/scikeras/_utils.py#L40-L44

scikeras._utils.TFRandomState controls the random seed for Python's random module and hash function, NumPy, Tensorflow. Given that, it might be better to rename call the public function as scikeras.utils.random_state.