Fix sample_weight performance problem

adriangb / scikeras

Scikit-Learn API wrapper for Keras.

https://www.adriangb.com/scikeras/

MIT License

239 stars 47 forks source link

Open richmanbtc opened 1 year ago

richmanbtc commented 1 year ago

The performance is degraded due to the wrong way of passing sample_weight to keras api.
https://github.com/keras-team/keras/pull/16177#discussion_r820162317

adriangb commented 1 year ago

So this "fix" makes legitimate tests fail. I'd also like to see a notebook showing performance degradation and how this fix addresses it.