adriangb / xpresso

A composable Python ASGI web framework
https://xpresso-api.dev/
MIT License
176 stars 4 forks source link

don't run sync dependencies in threads by default #109

Closed adriangb closed 1 year ago

adriangb commented 1 year ago

Not modifying the code that users give us by default seems like the most sensible thing to do.

codecov-commenter commented 1 year ago

Codecov Report

Merging #109 (7dbb3cb) into main (a292301) will decrease coverage by 0.09%. The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   98.44%   98.34%   -0.10%     
==========================================
  Files         127      123       -4     
  Lines        4231     4226       -5     
  Branches      598      417     -181     
==========================================
- Hits         4165     4156       -9     
- Misses         32       35       +3     
- Partials       34       35       +1     
Impacted Files Coverage Δ
xpresso/_utils/overrides.py 100.00% <ø> (ø)
xpresso/routing/operation.py 100.00% <ø> (ø)
xpresso/dependencies/_dependencies.py 86.20% <50.00%> (-13.80%) :arrow_down:
xpresso/_utils/endpoint_dependant.py 100.00% <100.00%> (ø)
xpresso/exceptions.py
xpresso/typing.py
xpresso/dependencies/__init__.py
tests/__init__.py