search

adriangb / xpresso

A composable Python ASGI web framework
https://xpresso-api.dev/
MIT License
178 stars 4 forks source link

feat: implement root_path parameter to App #63

Closed adriangb closed 2 years ago

adriangb commented 2 years ago

Closes #37

I realize the docs could be a lot better, that will have to be done in a second pass

codecov-commenter commented 2 years ago

Codecov Report

Merging #63 (68f36e3) into main (bf71495) will decrease coverage by 0.00%. The diff coverage is 97.36%.

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   97.48%   97.48%   -0.01%     
==========================================
  Files         141      142       +1     
  Lines        4532     4565      +33     
  Branches      580      585       +5     
==========================================
+ Hits         4418     4450      +32     
  Misses         71       71              
- Partials       43       44       +1
Impacted Files Coverage Δ
xpresso/applications.py 96.87% <94.44%> (-0.52%) :arrow_down:
tests/test_docs/advanced/test_root_path.py 100.00% <100.00%> (ø)
tests/test_routing/test_mounts.py 100.00% <100.00%> (ø)
adriangb commented 2 years ago

@sm-Fifteen tagging you in case you care to review, otherwise I'll probably merge Monday or something