adrianhajdin / banking

Horizon is a modern banking platform for everyone.
https://banking-jet.vercel.app
MIT License
1.13k stars 323 forks source link

Require some more error handling, and show error messages while sign up. #13

Open othegagan opened 1 month ago

othegagan commented 1 month ago

Hey @adrianhajdin,

Thank you for amazing and awasome tutorials like these and sharing the source code. I was facing some issues in signup, hence i cloned the repo and debugged it. If user enters some invalid details for date of birth, postal code, SSN or some other fields, it is resulting into errors

Error message : Creating a Dwolla Customer Failed: Error: {"code":"ValidationError","message":"Validation error(s) present. See embedded errors list for more details.","_embedded":{"errors":[{"code":"NotAllowed","message":"DateOfBirth value not allowed.","path":"/dateOfBirth","_links":{}},{"code":"InvalidFormat","message":"Ssn invalid.","path":"/ssn","_links":{}}]}}

Another thing, user would have enterd proper email, and we would have created the appwrite account/user and user tries to enter proper details later , appwrite is giving already account exists. I think we have to delete the appwrite user if Creation of Dwolla Customer Failed.

Thank You

OzgurTY commented 1 month ago

same problem, can anyone help with solution?

akashkumar23 commented 1 month ago

Same problem ? please help out.

othegagan commented 1 month ago

image

https://www.ssn-check.org/generate : use this site to generate a dummy SSN and give the rest of the details as in thescreenshot it will work. and you will be able to signup

akashkumar23 commented 1 month ago

Thank you @othegagan , it worked

gitdela commented 1 week ago

first of all, the date of birth is not correct. dwell requires yyyy-mm-dd, and the ssn says last 4 digits