search

adrianhajdin / iphone

Recreate the Apple iPhone 15 Pro website, combining GSAP animations and Three.js 3D effects. From custom animations to animated 3D models, this tutorial covers it all.
https://iphone-doc.vercel.app/
1.15k stars 208 forks source link

Not quite correct semantic structure in the Hero section, missing <h1> #1

Open getFrontend opened 7 months ago

getFrontend commented 7 months ago

For correct semantic structure when using the <section> tag, we must use at least one H1 or H2 header.

It would be more correct not to set a paragraph: <p id="hero" className="hero-title">iPhone 15 Pro</p>, but to make it a first-level heading: <h1 id="hero" className="hero-title">iPhone 15 Pro</h1>.

getFrontend commented 7 months ago

Also "Get the highlights." should be H2.