adrianhajdin / iphone

Recreate the Apple iPhone 15 Pro website, combining GSAP animations and Three.js 3D effects. From custom animations to animated 3D models, this tutorial covers it all.
https://iphone-doc.vercel.app/
1.03k stars 184 forks source link

10 improvements that will fix major bugs and make the project even more delightful! #8

Open getFrontend opened 6 months ago

getFrontend commented 6 months ago

Added the following improvements: 1) Improved tag semantics and proper header sequencing.

2) Page contains only one H1 heading, each section with <section> tag contains <h2> heading.

3) The <ul> tag is used for the list of links.

4) Correct scroll trigger is added for headings in Highlights and Model sections.

5) Added cursor-pointer in the Footer section to all links that could be clicked by the user.

6) Added dark scrollbar, which looks more harmonious with the main design.

7) Added indentation between paragraphs in the HowItWorks section to improve typography and readability.

8) Improved smooth scrolling on mobile devices (thanks to Bhaskarsahu23).

9) Fixed: correct display of footer on mobile devices.

10) Added --open option to automatically open the project in a browser after launching it with the npm run dev command.

aspectsiz commented 1 month ago

Thanks much