adrianhajdin / project_threejs_ai

https://jsmastery.pro
897 stars 267 forks source link

'toggle' #10

Open blaqbrane opened 1 year ago

blaqbrane commented 1 year ago

I added a new feature that toggles the editor tab contents(filepicker, colorpicker and aipicker) on and off on click. I discovered for example when the colorpicker is selected on mobile device after a different color is picked, the colorpicker still covers part of the model thereby preventing full visualization. Thanks for going through my little contribution.

Raspber commented 1 year ago

how did you handle having 2 onclick events?

blaqbrane commented 1 year ago

I used arrow function to handle the onClick event. It toggles the value of the isopen state variable and sets the activeEditorTab state variable based on the current value of isopen, it's just one onclick event.

On Thu, May 4, 2023, 23:11 Hauvert @.***> wrote:

how did you handle having 2 onclick events?

— Reply to this email directly, view it on GitHub https://github.com/adrianhajdin/project_threejs_ai/pull/10#issuecomment-1535475694, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZDLBTKR5NDTZ25OTD4HRFDXEQSRRANCNFSM6AAAAAAXRHS44E . You are receiving this because you authored the thread.Message ID: @.***>

Raspber commented 1 year ago

i like it. can we change the statements so if a tab is open and another tab is selected instead of closing the tab it should just switch the selected tab. then if you select the same tab it will close.

blaqbrane commented 1 year ago

Sure, I will do just that and let you know

On Sat, May 6, 2023, 20:22 Hauvert @.***> wrote:

i like it. can we change the statements so if a tab is open and another tab is selected instead of closing the tab it should just switch the selected tab. then if you select the same tab it will close.

— Reply to this email directly, view it on GitHub https://github.com/adrianhajdin/project_threejs_ai/pull/10#issuecomment-1537206750, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZDLBTJ5FW2MECQP3KMBMDTXE2QF3ANCNFSM6AAAAAAXRHS44E . You are receiving this because you authored the thread.Message ID: @.***>

blaqbrane commented 1 year ago

I have made the changes such that if a tab is open and a user selects another tab it switches to the new one and if the same tab is selected it closes the tab.

On Tue, May 9, 2023, 17:46 NNAMANI EBUBE @.***> wrote:

Sure, I will do just that and let you know

On Sat, May 6, 2023, 20:22 Hauvert @.***> wrote:

i like it. can we change the statements so if a tab is open and another tab is selected instead of closing the tab it should just switch the selected tab. then if you select the same tab it will close.

— Reply to this email directly, view it on GitHub https://github.com/adrianhajdin/project_threejs_ai/pull/10#issuecomment-1537206750, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZDLBTJ5FW2MECQP3KMBMDTXE2QF3ANCNFSM6AAAAAAXRHS44E . You are receiving this because you authored the thread.Message ID: @.***>

Raspber commented 1 year ago

thanks! im adding a product selector component to it. when i get it figured out all the way ill upload that as well.

chauhanarya007 commented 1 year ago

Thanks for improvements

blaqbrane commented 1 year ago

Hi Adrian I hope this finds you well, I created a web version of a job site using jsearch Api and React, would love your feedback thanks Below is the link to the site.

https://remotej.netlify.app

On Tue, May 9, 2023, 17:46 NNAMANI EBUBE @.***> wrote:

Sure, I will do just that and let you know

On Sat, May 6, 2023, 20:22 Hauvert @.***> wrote:

i like it. can we change the statements so if a tab is open and another tab is selected instead of closing the tab it should just switch the selected tab. then if you select the same tab it will close.

— Reply to this email directly, view it on GitHub https://github.com/adrianhajdin/project_threejs_ai/pull/10#issuecomment-1537206750, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZDLBTJ5FW2MECQP3KMBMDTXE2QF3ANCNFSM6AAAAAAXRHS44E . You are receiving this because you authored the thread.Message ID: @.***>