Closed PeterHeja closed 9 years ago
Thanks! I will be near computer next week. I will review it then. On Jun 25, 2015 9:54 AM, "Péter HÉJA" notifications@github.com wrote:
There were missing parentheses, which rendered the shell unusable with
Python3.
You can view, comment on, or merge this pull request online at:
https://github.com/adriank/ObjectPath/pull/33 Commit Summary
- Fixed missing parantheses to be Python3 compatible.
File Changes
- M objectpath/shell.py https://github.com/adriank/ObjectPath/pull/33/files#diff-0 (4)
Patch Links:
- https://github.com/adriank/ObjectPath/pull/33.patch
- https://github.com/adriank/ObjectPath/pull/33.diff
— Reply to this email directly or view it on GitHub https://github.com/adriank/ObjectPath/pull/33.
Hi @PeterHeja, would you mind removing the space before the paranthesis? print()
is a function in Python3+ and it should look like one.
@adriank If you use print
statement in other places you can always surround it like if print
would be a function. This way a lot of your code can be used in Python3+ and Python2 as well.
Hello @erikb85, I know they are unnecessary, but the other print statements that I saw in the code were also "print ()" instead of "print()", so I thought I should follow the convention. I just looked around a bit more in the code, and found that it's inconsistent wether it's written with or without a space. I will remove it sometime soon, then. Thank you for your advice.
It's reasonable. If all have the same format it's possible to change all at once later.
The parentheses were added automatically by 2to3. I haven't thoughtfully refactored the output since it's mess anyway. :)
There were missing parentheses, which rendered the shell unusable with Python3.