search

adriankarlen / textfox

firefox theme for the tui enthusiast
Mozilla Public License 2.0
583 stars 11 forks source link

urlbar dropdown selector color #4

Closed himangshusingh closed 1 week ago

himangshusingh commented 1 week ago

changed the url bar selector color to a darker shade from the pop pink color, added an attribute in userChrome.css to change it to any color suited texts are more readable now

909oce commented 1 week ago

you're setting a hardcoded color here, you should probably switch it to use a variable since it will not work with all colorschemes.

himangshusingh commented 1 week ago

yeah you are right, I'll make changes to use that

adriankarlen commented 1 week ago

As 909oce said I want the css to remain theme agnostic, if you are referring to this it is already set, however I can agree that it is a bit to poppy. image

Firefox uses the variable --urlbarView-highlight-background, which is overridden in variables.css. Will investigate if I can find a themed color or use color-mix that makes this work in a nice way.

adriankarlen commented 1 week ago

Closing this as I've resolved this in another PR, thanks for your contribution in ideas and insights.