search

adrianlee44 / atom-aligner

Easily align multi-line with support for different operators and custom configurations
https://atom.io/packages/aligner
MIT License
78 stars 3 forks source link

'undefined' was appended on the comment line when align across comments #23

Closed seoker closed 9 years ago

seoker commented 9 years ago

Hi, I've tried the 'Allow across comments' option, two problems: (1) when the selection include a comment at the first line, the aligner doesn't work. (2) the aligner appends some 'undefined' at the end of comment line. ex:

        // URL parameter missing
        UrlParameterMissing: 0x10000000,
        UserIdMissing:       0x10000001,
        CarIdMissing:     0x10000002,
        // Body parameter missing
        BodyParameterMissing: 0x11000000,
        MobileMissing:        0x11000001,
        PasswordMissing:   0x11000002,
        OtpMissing:         0x11000003,
        EmailMissing:     0x11000004,
        BirthdayMissing:      0x11000005,
        // Bad format
        BadMobileFormat:      0x12000001,
        BadOtpFormat:         0x12000002,
        BadEmailFormat:       0x12000003,
        BadBirthdayFormat:    0x12000004,

result:

        // URL parameter missing
        UrlParameterMissing:  0x10000000,
        UserIdMissing:        0x10000001,
        CarIdMissing:         0x10000002,
        // Body parameter missingundefined 
        BodyParameterMissing: 0x11000000,
        MobileMissing:        0x11000001,
        PasswordMissing:      0x11000002,
        OtpMissing:           0x11000003,
        EmailMissing:         0x11000004,
        BirthdayMissing:      0x11000005,
        // Bad formatundefined        
        BadMobileFormat:      0x12000001,
        BadOtpFormat:         0x12000002,
        BadEmailFormat:       0x12000003,
        BadBirthdayFormat:    0x12000004,
adrianlee44 commented 9 years ago

Thanks for reporting this. I'll look into this asap.

adrianlee44 commented 9 years ago

Patched above bugs with v0.15.0. Please let me know if you run into any more issues and thanks for reporting them.