New Update Breaks functionality

[Aaron-Pool]

Just downloaded the most recent update, and nothing happens upon running alignment. My specific use case is assignment operation are not being aligned. Please see the link below for demonstration.

https://i.gyazo.com/c1e54a445427cda5dddad9585374cf5c.mp4

[dwelle]

meanwhile, we can downgrade via apm install aligner@0.22.3 (that's the last version that works for me).

[adrianlee44]

Any chance you have https://atom.io/packages/aligner-javascript installed?

[adrianlee44]

Aligner v1+ removed the basic set of configurations and opted for language specific configurations. I thought I have added code to prompt user to install aligner-javascript but it seems like it wasn't working as I expected.

I have since fixed the issue with v1.2.0 and should now prompt you to install aligner-javascript. Hope this fixes the problem you were having.

[dwelle]

Yep, didn't notify before and now it does, and works properly. You still need to restart atom to be notified of the required dependency (not sure if it can be fixed).

[Aaron-Pool]

Ok, so that worked, and the package is now semi-functional. But the object-colon alignment setting doesn't seem to work anymore. No matter whether the box is checked or unchecked it still puts the space on the right side of the colon.

[adrianlee44]

Working on reproducing the issue.

Are you trying to convert

let test = {
  hello: 'world',
  a: 'test',
  aVeryLongString: 'orMaybeNot',
}

to

let test = {
  hello          : 'world',
  a              : 'test',
  aVeryLongString: 'orMaybeNot',
}

or

let test = {
  hello:           'world',
  a:               'test',
  aVeryLongString: 'orMaybeNot',
}

[Aaron-Pool]

First one :)

Btw, thank you so much for being so on the ball about this!

[Aaron-Pool]

OH NEVER MIND. I take back everything I said, I was using the settings on the original atom-package and I assumed that :-leftspace check box must be what I was looking for. I found the right setting on the new jaavscript-aligner package and everything is working fine.

[adrianlee44]

No worries. I'm glad you figured it out and it's working for you. Wasn't expecting the settings to linger in the aligner package. Might look into a way to clean that up.

[azawawi]

@adrianlee44 Thanks for all your excellent work.

I am having a similar problem since the new release with atom-aligner-python. Can you please check it out? Even a normal = alignment is not working without a downgrade.

[adrianlee44]

Can you file an issue on atom-aligner-python with a code sample you are trying to align? Thanks

[azawawi]

@adrianlee44 done

[adrianlee44]

Looks like most of the issues are now resolved with the new update. I'm going to close this issue. Please let me know if there are still issues.

[Aaron-Pool]

Thanks again @adrianlee44 ! This package fulfills all my hyper-perfectionist impulses, and I really appreciate you being so quick in getting any problems addressed.

Keep up the good work 👍

[azawawi]

@adrianlee44 Thanks for your excellent package. I use it everyday 👍