optional suppress_progress_messages, and better solved cube handling

adrianliaw / PyCuber

Rubik's Cube solver in Python

MIT License

199 stars 47 forks source link

optional suppress_progress_messages, and better solved cube handling #12

Closed jbwincek closed 8 years ago

jbwincek commented 8 years ago

This addresses the issues you raised in your comment to #11

FIXED: supress_progress_messages is now optional (I didn’t realize that got removed…) ADJUSTED: f2l solving now iterates through an enumerated F2LSolver, which more cleanly handles the stop iteration error. ADDED: tests for checking that the solver can complete both an actual solve and an non-solve solve without raising an error.

jbwincek commented 8 years ago

Oh, you beat me to it by two minutes. I tried to save you the trouble, but the tests might still be useful if you want to merge those in.

adrianliaw commented 8 years ago

Oops! Yeah I'll merge the tests, thanks @jbwincek