Completion of error handling

adrianlopezroche / fdupes

FDUPES is a program for identifying or deleting duplicate files residing within specified directories.

2.43k stars 187 forks source link

Completion of error handling #109

Open elfring opened 6 years ago

elfring commented 6 years ago

Would you like to add more error handling for return values from functions like the following?

printf ⇒ printmatches
strdup ⇒ grokdir

adrianlopezroche commented 6 years ago

For strdup, yes. For printf... why?

elfring commented 6 years ago

I suggest to avoid ignorance of return values a bit more.

Would you like to detect every error situation as early as possible?
Do you care for file output failures?

adrianlopezroche commented 5 years ago

Fixed for strdup in grokdir, commit c671a2b.

Dealing with printf seems rather more complicated, as it returns a positive number of bytes read even when output is redirected to /dev/full. I don't know how to get printf to return an error when stdout is full.

elfring commented 5 years ago

Can you get any further software development ideas from the following command example?

elfring@Sonne:~> LANG=C echo X > /dev/full
bash: echo: write error: No space left on device