search

adrianlopezroche / fdupes

FDUPES is a program for identifying or deleting duplicate files residing within specified directories.
2.48k stars 186 forks source link

File mtime is now shown in ISO-8601 format alongside the filenames of dupes during interaction deletion. #125

Closed jakem72360 closed 5 years ago

jakem72360 commented 5 years ago

This feature is intended to make the user's life easier as some sorting decisions may be based on the age difference between duplicate files.

I wasn't able to add the timestamp display to the ncurses TUI version of the utility, as I couldn't for the life of me locate where the filenames are printed (either by regex or reading the code). If you have a file and line # for me to look at, I'd be more than happy to add it to the TUI as well :)

adrianlopezroche commented 5 years ago

This should probably be an option rather than the default. Maybe somehing like --time, with options (--time=[option]) mtime, ctime, and atime, with mtime used when --time is given without an option.

The ncurses code is rather complicated because of the need for cursor movement and paging, but I'll let you know. In any case, if the feature is to be included it would have to be available in both modes.

Thanks.

On Sat, Sep 14, 2019, 5:25 AM jakem72360 notifications@github.com wrote:

This feature is intended to make the user's life easier as some sorting decisions may be based on the age difference between duplicate files.

I wasn't able to add the timestamp display to the ncurses TUI version of the utility, as I couldn't for the life of me locate where the filenames are printed (either by regex or reading the code). If you have a file and line # for me to look at, I'd be more than happy to add it to the TUI as well :)

You can view, comment on, or merge this pull request online at:

https://github.com/adrianlopezroche/fdupes/pull/125 Commit Summary

  • File mtime is now shown in ISO-8601 format alongside the filenames of

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/adrianlopezroche/fdupes/pull/125?email_source=notifications&email_token=ABPQT7OTWGN6EQOIYI6EQQ3QJSUXDA5CNFSM4IWWPUV2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HLLZRDA, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPQT7KIORPXELZPF2PY3OLQJSUXDANCNFSM4IWWPUVQ .

adrianlopezroche commented 5 years ago

I took your changes and incorporated them into fdupes master as an option (--time). This will work in all modes: list, interactive (ncurses), and interactive (plain). Thanks.

jakem72360 commented 5 years ago

Thanks. Sorry I wasn't able to help with the ncurses UI :)