adrianlopezroche
commented
4 years ago You're right, directory sizes should be ignored completely. Thanks for the bug report.
On Sat, Dec 28, 2019, 10:52 AM valentijnscholten notifications@github.com wrote:
The --minsize and --maxsize are very useful and the primary reason for me to build my own binary with these unreleased features.
However they don't work when recursing into (sub)directories.
On my filesystem directories are 4096 bytes, so any value for minsize above that will skip the directory, basically skipping everything.
example command: ./fdupes -r /hd6/backup --minsize=4097
will skip all directories inside /hd6/backup because they are only 4096 bytes.
I am not a C(++) programmer so can't easily provide a reliable PR, but at first thought the size check should not be performed for directories I think?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/adrianlopezroche/fdupes/issues/128?email_source=notifications&email_token=ABPQT7OY6UO2YJNFLKUCGULQ25R4BA5CNFSM4KANXJLKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IDAQXXQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPQT7P2FQRQKYE5TQVBRTTQ25R4BANCNFSM4KANXJLA .
valentijnscholten
The --minsize and --maxsize are very useful and the primary reason for me to build my own binary with these unreleased features.
However they don't work when recursing into (sub)directories.
On my filesystem directories are 4096 bytes, so any value for minsize above that will skip the directory, basically skipping everything.
example commands: ./fdupes -r /hd6/backup --minsize=4097 ./fdupes -R /hd6/backup --minsize=4097
will skip all directories inside /hd6/backup because they are only 4096 bytes.
I am not a C(++) programmer so can't easily provide a reliable PR, but at first thought the size check should not be performed for directories I think?