Bugfix: when no satellite in view, GSV failed

adrianmo / go-nmea

A NMEA parser library in pure Go

MIT License

227 stars 78 forks source link

Bugfix: when no satellite in view, GSV failed #82

Closed bezineb5 closed 2 years ago

bezineb5 commented 2 years ago

Hi!

I found and fixed a bug in your (otherwise excellent!) library. When the GPS/GNSS has no satellite in view, GSV sentence parsing failed. This was a simple index check issue. Exemple failing sentence: $GAGSV,1,1,00,0*74

Thanks!

icholy commented 2 years ago

@bezineb5 I pushed a v1.4.1 tag.

adrianmo commented 2 years ago

@bezineb5 thanks for the contribution! And thanks to @icholy as well for the quick review! 💯