PCF-33P-1 thread - Githubissues

adrianschlatter / threadlib

thread library for OpenSCAD

BSD 3-Clause "New" or "Revised" License

351 stars 34 forks source link

PCF-33P-1 thread #27

Closed adrianschlatter closed 4 years ago

adrianschlatter commented 4 years ago

Added external PCF-33P-1 thread based on proposal by @dholth in #26 but

changed order of points in profile
flipped so that load-side of thread is on top
changed pitch from 6.35 mm to 3.18 mm

Added internal PCF-33P-1 thread to sensibly match external thread (spec defines only external thread, not internal thread).

Added unit tests checking slopes on load and non-load sides.

adrianschlatter commented 4 years ago

Will not merge. @dholth pointed out (correctly) that PCF-33P-1 has 2 thread starts, i.e., this PR does not provide PCF-33P-1. threadlib does not support multiple thread starts (yet). For now, this PR is closed. Try again as soon as threadlib has multiple thread starts.