Duplicates in THREAD_TABLE.scad

adrianschlatter / threadlib

thread library for OpenSCAD

BSD 3-Clause "New" or "Revised" License

351 stars 34 forks source link

Duplicates in THREAD_TABLE.scad #66

Closed CrashCash closed 2 years ago

CrashCash commented 2 years ago

Just wanted to mention a lot of the lines (924 to be exact) in THREAD_TABLE.scad are duplicates. This brings the line count from 2,825 to 1,901.

adrianschlatter commented 2 years ago

Indeed. I think that happens when long and short designators of the thread are identical. We should only generate the long descriptor when it is different from the short descriptor.

adrianschlatter commented 2 years ago

Fixed in 75814d20136a954bfe551fb9dd5ae21f03ea1ee2