adrianschlatter / threadlib

thread library for OpenSCAD
BSD 3-Clause "New" or "Revised" License
351 stars 34 forks source link

Added RMS threading https://www.thorlabs.com/newgrouppage9.cfm?object… #74

Closed ccrome closed 1 year ago

ccrome commented 1 year ago

…group_id=4960

Hi there, I added a microscope objective lens thread called RMS. I just tested it on a microscope objective and it works swimmingly.

adrianschlatter commented 1 year ago

Hey @ccrome

Thanks for supporting threadlib! And I'm glad you got your RMS thread problem solved. Regarding addition to threadlib, we still have to tackle a hurdle, though: Any direct modifications to THREAD_TABLE.scad will - unfortunately - get lost upon build because that file is autogenerated.

To make the change permanent, we need to add the rules to generate the thread specs to the build system. This involves creating of design/RMS_thread.csv and design/RMS_thread.awk (see here). Usually, such an .awk file will generate an entire family of threads. For rms, it will only add two threads (ext and int). This is very similar to the PCO-threads we already have: Would you have a look at design/PCO_thread.csv and design/PCO_thread.awk and try to use the same approach we have there?

In plain English what the PCO approach does is:

ccrome commented 1 year ago

perhaps I should have read the CONTRIBUTING.md file :)

I just pushed a new version.

-Caleb

adrianschlatter commented 1 year ago

Hey Caleb

Thanks! I'll merge this and add tests.