adriantofan / ATCalendar

Other
1 stars 0 forks source link

Missing import "NSManagedObject+MagicalRecord.h" in ATCalendar.m #2

Closed Narayane closed 8 years ago

Narayane commented 8 years ago

Hi,

I have another problem with MR_* directives.

at_missing

it misses #import "NSManagedObject+MagicalRecord.h" in ATCalendar.m in this case but when I add it, same error appears in others files. Can you add this import in your .pch file please ?

Thanks

adriantofan commented 8 years ago

the MR_ stuff is now inside <MagicalRecord/MagicalRecord.h> and as you can see I've updated the project to use it. Maybe we are not using the same version of Magical Record ? Anyway, if you wish to use another version of MagicalRecord you can fork the project, the fix for your last issue is easy to find in my last commit

Narayane commented 8 years ago

I use 'MagicalRecord', '2.2'

adriantofan commented 8 years ago

in the project you have the Podfile.lock file and you can compare versions with yours. maybe is a cocoapods incompatibility. I've switched to 0.39.0. For me it compiles just fine.

Narayane commented 8 years ago

Hi,

what I understand of my problem is you use MagicalRecord Shorthands mechanism by calling MR_methods.

But, when I use your pod, all MR_methods of your pod code are unrecognized because of #import < MagicalRecord/MagicalRecord.h > use instead of #import "CoreData+MagicalRecord.h". (https://github.com/magicalpanda/MagicalRecord/issues/403)

I can solve this problem by replacing the first import by the second by unlocking your pod code but it is not a good solution from my point of view.

Would it be possible that you define MR_SHORTHAND before #import "CoreData+MagicalRecord.h" in your pch file and remove any # import < MagicalRecord/MagicalRecord.h > occurrences in your ATClasses ?

Thanks.

adriantofan commented 8 years ago

I remind you that if you download the test project everything works fine, so the problem must be in your setup. As I've explained you previously either your pods(your libraries) are different or cocoapods is different. Don't look for another fix.

If you don't want or can't change your setup, fork the project and apply my last fix (one line of code) to your fork, than use your fork.

On 1 mars 2016, at 15:32, Sébastien BALARD notifications@github.com wrote:

Hi,

what I understand of my problem is you use MagicalRecord Shorthands mechanism by calling MR_methods.

But, when I use your pod, all MR_methods of your pod code are unrecognized because of #import use instead of #import "CoreData+MagicalRecord.h". (magicalpanda/MagicalRecord#403 https://github.com/magicalpanda/MagicalRecord/issues/403)

I can solve this problem by replacing the first import by the second by unlocking your pod code but it is not a good solution from my point of view.

Would it be possible that your define MR_SHORTHAND before #import "CoreData+MagicalRecord.h" in your pch file and remove any # import occurrences in your ATClasses ?

Thanks.

— Reply to this email directly or view it on GitHub https://github.com/adriantofan/ATCalendar/issues/2#issuecomment-190742968.

adriantofan commented 8 years ago

this is the one line fix that I was telling you about

minimal_fixes_sot_that_it_builds_with_version_7_2_1_ _adriantofan_atcalendar_3ac400e

inside of Classes/Models/ATEvent+LocalNotifications.m

legars commented 8 years ago

Hi,

We have a problem with the latest version. Now when I change the selectedDisplayStyle with the segCtrl we have bug. My application freeze. I search for a workaround but without success. It seems that the problem is with MagicalRecord and performBlockAndWait function.

The problem is not present on iOS 7 but only on iOS 8 and more.

Thanks for your answer

Regards

adriantofan commented 8 years ago

I am sorry, but I am not supporting this project anymore.