adriantr09 / gecko-mediaplayer

Automatically exported from code.google.com/p/gecko-mediaplayer
GNU General Public License v2.0
0 stars 0 forks source link

NPP_Initialize not available anymore in XUL 2.0beta10 (Fails to compile) #124

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
With the latest beta release of Firefox/xulrunner/whatever, 2.0 beta 10, 
gecko-mediaplayer doesn't compile anymore:

np_entry.cpp: In function 'NPError NP_Initialize(NPNetscapeFuncs*, NPP
luginFuncs*)':
np_entry.cpp:178:20: error: 'NPP_Initialize' was not declared in t
his scope

I don't really understand the change since it isn't very documented and I never 
used the API. The relevant links:
https://bugzilla.mozilla.org/show_bug.cgi?id=623695
http://code.google.com/p/npapi-headers/source/detail?r=33

From the "Remove unused functions NPP_Initialize and NPP_Shutdown." I 
understand the NPP_Initialize call could just be removed from 
gecko-mediaplayer, but...

Original issue reported on code.google.com by Christia...@gmail.com on 28 Jan 2011 at 7:12

GoogleCodeExporter commented 8 years ago
Gosh those people at Mozilla drive me crazy with the constant API changes...

np_entry.cpp and npp_gate.cpp come from the xulrunner kit, so you can probably 
just replace them...

Original comment by kdeko...@gmail.com on 28 Jan 2011 at 7:19

GoogleCodeExporter commented 8 years ago
Not sure what "xulrunner kit" is. But if you refer to 
http://hg.mozilla.org/mozilla-central/file/2926ad5face7/modules/plugin/sdk/sampl
es/npruntime/np_entry.cpp... it still uses NPP_Initialize xD
But since 
http://hg.mozilla.org/mozilla-central/file/2926ad5face7/modules/plugin/sdk/sampl
es/npruntime/npp_gate.cpp defines the function as

NPError NPP_Initialize(void)
{
    return NPERR_NO_ERROR;
}

I just deleted the function call from gecko-mediaplayer and... it works fine in 
my openSUSE 11.3 system (xulrunner 1.9.2.13).

Original comment by Christia...@gmail.com on 28 Jan 2011 at 7:56

GoogleCodeExporter commented 8 years ago
Which file did you delete it from? np_entry.cpp?

Original comment by kdeko...@gmail.com on 28 Jan 2011 at 8:01

GoogleCodeExporter commented 8 years ago
Yes

Original comment by Christia...@gmail.com on 28 Jan 2011 at 8:03

Attachments:

GoogleCodeExporter commented 8 years ago
Applied

Original comment by kdeko...@gmail.com on 28 Jan 2011 at 8:08