adrianvlupu / C4-Builder

This is a documentation builder. You feed it .md and .puml and it exports a site, pdf, or a markdown with navigation.

https://adrianvlupu.github.io/C4-Builder/

MIT License

563 stars 93 forks source link

Add support for inlining diagram images as data URIs #24

Closed jikuja closed 3 years ago

jikuja commented 3 years ago

Add support to select diagram image format because browsers and markdown application are flaky with SVG
Add support to inline diagram images as data URIs.
- Provides a way to create self-contained Markdown and HTML files(if complete markdown file is converted to HTML)

To be solved:

Is it feasible to inline automatically all markdown image references. Is it needed?

adrianvlupu commented 3 years ago

Thanks for the PR, I'll come back to it after I push the other changes.

adrianvlupu commented 3 years ago

Hi,

While merging the other pull request regarding embedding svg diagrams into markdown, I accidently re-created this pull request. The option is available inside the config.

Sorry for not merging this first. I probably saw it and confused the two. I'll see if I can merge this as well

jikuja commented 3 years ago

No problem. I'll check my PR, needs and current code and then re-evaluate if this PR is needed.

645b0e25ebddd38c37e1226bfd818eac0e33d99f probably implemented everything in my PR.