search

adrianvlupu / C4-Builder

This is a documentation builder. You feed it .md and .puml and it exports a site, pdf, or a markdown with navigation.
https://adrianvlupu.github.io/C4-Builder/
MIT License
563 stars 93 forks source link

The c4-plantuml files in the adrianvlupu cause an error #8

Closed kevinbader closed 4 years ago

kevinbader commented 4 years ago

The template refers to https://raw.githubusercontent.com/adrianvlupu/C4-PlantUML/latest/C4_Deployment.puml

When I use c4builder new and don't change anything I see this error:

image

With the c4-plantuml files from https://github.com/RicardoNiepel/C4-PlantUML it works (on both master and release-1-0 branches).

zarathon commented 4 years ago

I got the same issue here, to fix it, change my include to use previous version: 1.2019.09 Just change latestto use 1.2019.09 on include.

Sample !include https://raw.githubusercontent.com/adrianvlupu/C4-PlantUML/1.2019.09/C4_Deployment.puml

adrianvlupu commented 4 years ago

Really sorry about this, all my projects broke when the plantuml server switched to 1.2020.07. I am working on a local version that downloads the c4-plantuml locally and let's you choose the plantuml version.

adrianvlupu commented 4 years ago

I have updated the project to use different versions of PlantUML and C4-Plantuml. This should make it easier to maintain if you generate the diagram images locally.

The original C4-PlantUML still works because even though https://plantuml.com/preprocessing states that

You should not use !define and !definelong anymore. Use !function, !procedure or variable definition instead. !define should be replaced by return !function and !definelong should be replaced by !procedure.

since 2019, they never removed it. It's the main reason why that original repository was no longer updated.