search

adridadou / eth-contract-api

EthereumJ native API or how to call contracts easily and with type safety
http://www.davidroon.com/ethcontractapi/
Apache License 2.0
60 stars 34 forks source link

Add a way to deploy the contracts with a created CompilationResult. #64

Closed UrsZeidler closed 7 years ago

UrsZeidler commented 7 years ago

Why not provide a way to deploy the contracts via org.ethereum.solidity.compiler.CompilationResult because a created and configured CompilationResult could be make from every parser by hand (hardcoded) also by tool.

This would helps a bit for #36 and followings because the solc compiler did the resolving, and also for #50 as it give a way to use the own compiler not a provided one.(Maybe you want to build the compiler your self.)

adridadou commented 7 years ago

Interesting idea. If we want to go this road, I think we need to think a bit more what represents a CompilationResult.

I want to keep the API as neutral as possible so using the EthereumJ class is suboptimal I think.

I would take the idea a bit further and try to create an abstract interface to deploy a smart contract. This could be the source code, compiled raw data, any other thing ...

adridadou commented 7 years ago

Actually I had to do that for me to remove duplicated code for compilation