All transactions are DROPPED at one stage

adridadou / eth-contract-api

EthereumJ native API or how to call contracts easily and with type safety

http://www.davidroon.com/ethcontractapi/

Apache License 2.0

60 stars 34 forks source link

All transactions are DROPPED at one stage #73

Closed kivanov82 closed 7 years ago

kivanov82 commented 7 years ago

Might be related to #72 but at one stage the queue of pendingTransactions in BlockchainProxyReal doesn't get cleaned which leads to the incorrecly calcualated nonce so that all the subsequent transactions are dropped either.

Not sure about the 'at one strage' yet, but seams shooting 10-15 transactions every second-two will lead to that.

adridadou commented 7 years ago

I have to write tests about that. But my suspicion is:

you send 15 transactions (almost) at once.
You calculate the nonce for each of them
The third transaction is being dropped
You have now a "hole" in your nonce, and that makes all the other transactions being dropped

adridadou commented 7 years ago

A possible solution to mitigate the issue: for each tx, instead of calculating the nonce you first check if there is a slot somewhere if there is, then you use it otherwise you calculate it it won't solve the issue entirely but will mitigate the issue

adridadou commented 7 years ago

I suspect now that this was an issue due to the mismanagement of gasLimit. @kivanov82 can u pull develop and try again and let me know if you still have many dropped tx ?

adridadou commented 7 years ago

After a few discussions with @kivanov82 it seems that this is not a problem anymore. I propose to close this one and open it again if the problem resurface