GH-8 - rxJava + web3j updated and unit tests fixed

adridadou / eth-propeller-core

Core library for Ethereum propeller

Apache License 2.0

26 stars 16 forks source link

GH-8 - rxJava + web3j updated and unit tests fixed #27

Closed fforbeck closed 5 years ago

fforbeck commented 5 years ago

[x] Web3j updated to v4.1.1
[x] RxJava updated to 2.2.6
[x] Fixed breaking changes using the new Observable and Subscriber APIs
[x] Replaced the while(true) with Observables
[x] Fixed unit tests
[x] Converted Observables to Flowables with Buffer backpressure strategy
[x] Added tests to simulate concurrent transactions

Closes #8

fforbeck commented 5 years ago

Some notes:

The new Observable doesn't support backpressure, if we want that we need to change it to Flowable.
I've removed the blocking queue because we can publish the new tx straight into the PublishSubject.
I've changed the Future hashmap to use the ConcurrentHashMap impl so it handles the locking for us.

@adridadou please take a look when you get a chance.

fforbeck commented 5 years ago

Please don't merge that yet. I am writing some stress tests.

fforbeck commented 5 years ago

This is ready for review @adridadou I've changed from Observable to Flowable to add buffer backpressure support. It is recommend when we have larger streams that have IO and blocking ops. Besides that, minor fixes + a simple test scenario that sends concurrent transactions.