adrien2p / medusa-extender

:syringe: Medusa on steroid, take your medusa project to the next level with some badass features :rocket:
https://adrien2p.github.io/medusa-extender/
MIT License
320 stars 38 forks source link

Compatible with Medusa 1.8? #193

Closed eparizzi-clevertech closed 1 year ago

eparizzi-clevertech commented 1 year ago

I'm not being able to install medusa-extender 1.8.8 into a fresh Medusa 1.8 project.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: medusa-starter-default@0.0.1
npm ERR! Found: typeorm@0.3.14
npm ERR! node_modules/typeorm
npm ERR!   typeorm@"^0.3.11" from the root project
npm ERR!   peer typeorm@"^0.3.11" from @medusajs/medusa@1.8.1
npm ERR!   node_modules/@medusajs/medusa
npm ERR!     @medusajs/medusa@"^1.8.0" from the root project
npm ERR!     peer @medusajs/medusa@"^1.7.2" from medusa-extender@1.8.8
npm ERR!     node_modules/medusa-extender
npm ERR!       medusa-extender@"*" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer typeorm@"^0.2.41" from medusa-extender@1.8.8
npm ERR! node_modules/medusa-extender
npm ERR!   medusa-extender@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Is this just a peer dependency problem and just releasing a new version of the extender with the upgraded TypeORM dependency would solve the issue? Or since Medusa 1.8 introduces some big changes, the extender will need to be modified significantly to support it?

adrien2p commented 1 year ago

As mentioned multiple times, the pr allows the compatibility with medusa 1.8 but you need to fork and pack the package. But since now we have made it possible to do it in medusa directly, this package will be deprecated.

Also, if you read the error message it tells you exactly your issue, wrong typeorm version 😌