Features: #123 Array like options

adrien2p / medusa-plugins

A collection of awesome plugins for medusa :rocket:

https://medusa-plugins.vercel.app

MIT License

144 stars 42 forks source link

Features: #123 Array like options #124

Closed stephane-segning closed 7 months ago

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
medusa-plugins	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 4, 2023 10:49am

stephane-segning commented 7 months ago

@adrien2p please test this and tell me :)

adrien2p commented 7 months ago

I ll do it as soon as I can 😊 thanks a lot. We will also have to update the documentation to mention that you can now pass an array of object/function. I think ill also do some helpers for the test for example the container mock and things like that

stephane-segning commented 7 months ago

Good ideas!

Implementing new examples would be much more helpful for newbies.
Having better doc is a foundation for us but for other developers too for having good code. Tell me when you're doing, I'll like to help :)

adrien2p commented 7 months ago

If you have any idea to make the doc better i would be glad to look at your suggestions 🎉very happy to have you help me on the plugin. As you know i am pretty busy and i am trying to find time to look at your current prs 🤣

stephane-segning commented 7 months ago

@adrien2p please review it again

adrien2p commented 7 months ago

Yes i will as soon as i can, i do it in my free time and i am a dad as well while i work at medusa 😉

Ill review it by the end of the day

stephane-segning commented 7 months ago

Ive not tested it yet through and through. Still doing it though, but I'm not having errors till now. So I believe it's ok.

Also working on a doc directly after is a good idea. Don't just deploy it for now 😊