search

adrienbrignon / mkdocs-exporter

⚡ The fastest and most configurable plugin for MkDocs, allowing seamless export of individual pages and/or entire documentation as PDF documents.
https://adrienbrignon.github.io/mkdocs-exporter/
MIT License
81 stars 8 forks source link

FEATURE REQUEST - drawio support #6

Closed mat-inf closed 1 year ago

mat-inf commented 1 year ago

Hey,

Thanks for creating such a useful mkdocs plugin. I really like your work! As you mentioned on the Repositories README, I would like to request an additional feature:

Currently, I'm using a plugin for embedding drawio diagrams into mkdocs (More Information about the Plugin). Basically, the plugin simplifies the workflow of embedding a diagram by allowing to embed the .drawio file directly instead of exporting the diagram to a .svg and embed this. I tried to export PDFs with your exporter, which works perfectly fine, but I wasn't able to export a site with the drawio Diagram. There was no Error and the export works, the diagram just wasn't showing in the exported PDF. So my guess was that this is just not supported by your plugin.

I would be very happy if you could include this feature. Feel free to contact me about further questions or if I can be of assistance.

adrienbrignon commented 1 year ago

Hey @mat-inf,

First of all, thank your for submitting an issue and for your kind words.

That's a great idea!
I'll see what I can do in implementing this feature; stay tuned.

adrienbrignon commented 1 year ago

Hello again @mat-inf,

Could you please try updating to v3.0.3 and tell me if that works now?

It seems that the diagrams do not properly scale when rendered in a PDF document. I guess that this could be fixed with some CSS/JS but it is currently out of the scope of this project.

mat-inf commented 1 year ago

Hey @adrienbrignon

I did the upgrade to v3.0.3 and it works now. Is this feature now integrated or was this just a workaround?

adrienbrignon commented 1 year ago

Thanks for testing, glad to hear that it works now!

This was a simple workaround, re-enabling JavaScript in the browser rendering PDF documents fixed the issue 😄

mat-inf commented 1 year ago

Thanks a lot!