adrienemery / lnd-grpc-client

A python grpc client/async client for LND ⚡⚡⚡
MIT License
35 stars 21 forks source link

Add support for hold invoices #13

Open takinbo opened 5 years ago

takinbo commented 5 years ago

With lnd 0.6, support for hold invoices has been merged. Hold invoices allow merchants to delay the settlement of invoices until conditions for fulfilling the service has been met - say for instance an inventory check. see here.

This pull request merges support for creating, settling and cancelling hold invoices into the lnd-grpc-client library. There were a few backwards-compatible changes to the regular rpc protocol buffers: support for static channel backups, new address types, peer states and a new descriptor for utxos were added. For a full list of the changes, please consult the diff.

dgnsrekt commented 5 years ago

Do I still need to use make with tags="invoicesrpc" flag to take advantage of hodl invoices in lnd v0.6?

takinbo commented 5 years ago

@dgnsrekt Yes you do. v0.6 is currently at rc4 so still requires building with the invoicesrpc subserver.

takinbo commented 5 years ago

Force push was an amendment to the last commit to add the new whitespace characters that keep showing up every time I recompile the protocol buffers. This update will ensure the next compile doesn't mark the file as having an update when it doesn't include any new changes.

kornpow commented 3 years ago

Check out https://github.com/sako0938/lnd-grpc-client if you want, Im starting to add support for more subsystems, but Im just a beginner at async programming!