search

adrienjoly / chrome-next-step-for-trello

✅ Chrome extension to check tasks directly from your Trello boards
https://adrienjoly.com/chrome-next-step-for-trello
72 stars 24 forks source link

Popups from power-up "Chronos Timetracker" cannot close #95

Closed adrienjoly closed 4 years ago

adrienjoly commented 4 years ago

Observed behavior when clicking the "close" button, while Next Step for Trello is active:

Kapture 2020-05-23 at 15 58 52

Reported by Sergei, by email.

Note: the JS console has the same errors, even when NSTrello is not active:

without nstrello 1 without nstrello 2
adrienjoly commented 4 years ago

Investigation:

image

Commenting lines 604 to 608 of installToolbar() prevents the issue.

adrienjoly commented 4 years ago

Update: just commenting the line document.body.appendChild(popover) prevents the issue.

adrienjoly commented 4 years ago

Update: just commenting the line node.className = 'pop-over' prevents the issue, but it also prevents NSTrello to open its own pop-over menu.

adrienjoly commented 4 years ago

:tada: This issue has been resolved in version 1.19.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: