adrienjoly / js-test

💯 Exerciseur / outils d'évaluation d'étudiants -- NOT MAINTAINED ANYMORE
https://js-test-demo.firebaseapp.com/
MIT License
42 stars 9 forks source link

BUG: cannot login if localstorage / sessionstorage (privacy) was disabled on Chrome #14

Closed adrienjoly closed 4 years ago

adrienjoly commented 7 years ago

identified from https://js-code.herokuapp.com (js qcm 5) by alexandre blanc.

cause:

when localstorage was disabled by the user on Chrome, the google-signin element fails to load:

644096210-idpiframe.js:12 Uncaught DOMException: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.(…)

image

same problem cited there:

solutions:

1) re-enable localstorage on Chrome: http://stackoverflow.com/questions/24456891/iframe-in-chrome-error-uncaught-securityerror-failed-to-read-the-sessionstora

2) add accounts.google.com to exception list: https://github.com/GoogleWebComponents/google-signin/issues/99 (instructions en français)

adrienjoly commented 7 years ago

for reference, full error:

Uncaught DOMException: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.
    at x.C (https://ssl.gstatic.com/accounts/o/1921062015-idpiframe.js:12:285)
    at Object.k.ub (https://ssl.gstatic.com/accounts/o/1921062015-idpiframe.js:8:121)
    at S.h.start (https://ssl.gstatic.com/accounts/o/1921062015-idpiframe.js:50:170)
    at Object.Bb [as startIdpIFrame] (https://ssl.gstatic.com/accounts/o/1921062015-idpiframe.js:84:713)
    at https://accounts.google.com/o/oauth2/iframe:1:414
adrienjoly commented 7 years ago

Behavior tests:

adrienjoly commented 7 years ago

https://github.com/GoogleWebComponents/google-signin/issues/99#issuecomment-287895202 => suggestion: have a timeout display a message to the user, after a few seconds without successful login.

adrienjoly commented 4 years ago

Closing in favor of #58.