search

adrienluitot / surfshark-linux-client

Surfshark Linux Client is simply a client for Linux for the VPN SurfShark. It’s made with python 3 and PyGObject (GTK).
MIT License
9 stars 2 forks source link

Change text default colours #7

Open adrienluitot opened 4 years ago

adrienluitot commented 4 years ago

If we use the default colours, the application use theme's default colours, which could lead to unwanted results.

Like here, the text is too light. image

VladKappa commented 4 years ago

I tried to address that: VladKappa@5f79d3d24d692d9913c93d5476330453cd88ff11 Here's the result: Screenshot at 2020-06-23 19-26-23

The color can be changed via the variable color. Let me know if that's a good solution!

adrienluitot commented 4 years ago

Hey !

Thanks for your investment :D

I would use a css class (for an example you can check line 75 of the main_window.py file) and the css file (style/style.css) so it fits with the whole code (I prefer to split python and style). Also I would use a colour more in the style of the application, like a light grey (but no too much ^^), like #acbac9 or maybe #9caab9.

VladKappa commented 4 years ago

Do you want me to work on that?

Also, is there a python visual editor or something? I made the edits in vim.

adrienluitot commented 4 years ago

If it attracts you :D

There is a lot of them yes ^^ you have few light ones like VSCode, Atom or Sublime Text, and also bigger ones like PyCharm. (PyCharm doesn't really like css though, where the others are more modular)