License

[dcheckoway]

Adrien,

Your work on eredis_cluster is much appreciated. Would you be willing to add a license to this repo?

http://choosealicense.com

--Dan

[adrienmo]

Dan,

I have added the MIT license to the project.

I also fixed the concurrency issue you mentioned in your pull request in the forked project of layerhq, the new version is tagged 0.3.0, please have a look !

[dcheckoway]

@adrienmo Thanks so much for adding the license!

Your concurrency fix looks good. My feedback, fwiw, is:

• We added "versioning" of the cluster state in order to avoid excessive reloads. i.e. if 20 processes were all to invoke eredis_cluster_monitor:initialize_slots_cache, it might reload 20 times. And the 20th caller would wait longer than necessary. By versioning, we implemented it so that the first caller actually does the reload, and any other callers with the previous version of state wouldn't bother with a duplicate reload.
• By still forcing every process to go through a gen_server to get the pool for the slot, it's still a bottleneck. It's much better than it was, but we felt there was room to go even further with it. We put cluster state in ETS, where any number of processes can access it concurrently. The only bottleneck with that approach is the pool.

Thanks!

[adrienmo]

Thanks for the insights, I implemented your suggestions !