search

adrienpoly / rubyvideo

Indexing all Ruby related videos
https://rubyvideo.dev
196 stars 30 forks source link

Implement `mp4` video provider and add Brighton Ruby 2023 videos #167

Open marcoroth opened 1 month ago

marcoroth commented 1 month ago

This pull request implements a new video_provider for the case where the videos are not hosted on YouTube. In the case of Brighton Ruby they are hosted on their own website.

So this pull request implements a new mp4 video provider, where the video_id is the link to the MP4 file.

CleanShot 2024-08-26 at 22 05 36

adrienpoly commented 1 month ago

Thanks for this great addition.

I think we should ask @andycroll permission first. Organizers who are publishing their videos on Youbute defacto accept that their video can be embedded into another website as it is a native feature of Youtube. Also videos viewed from embedded players do count for the view stats on Youtube.

For orgs having made the choice to host by themself the videos, I think we should get their explicit consent first.

One option could be that we just pull the metadata + Thumbnail and link to the Org website for the player (to be decided by the org)

marcoroth commented 1 month ago

Good point, I'm more than happy to extract the video provider to its own pull request, since it's technically two "features" in one pull request.

I was just testing the mp4 "provider" with the lastest Brighton Ruby edition, since I knew they were using their own video hosting.

adrienpoly commented 1 month ago

Good point, I'm more than happy to extract the video provider to its own pull request, since it's technically two "features" in one pull request.

I was just testing the mp4 "provider" with the lastest Brighton Ruby edition, since I knew they were using their own video hosting.

I will send an email to Andy. Don’t change anything for now