hide the window when the window already at the front.

adrienverge / gnome-magic-window

Bind a key to a specific program in Gnome Shell.

GNU General Public License v3.0

31 stars 8 forks source link

hide the window when the window already at the front. #12

Open jixiuf opened 1 year ago

jixiuf commented 1 year ago

close https://github.com/adrienverge/gnome-magic-window/issues/11

adrienverge commented 1 year ago

Hello, I don't understand the initial problem nor issue #11. Could you explain what you're trying to solve, and what this commit is supposed to do?

jixiuf commented 1 year ago

When the corresponding key is pressed and this program is in background, its window is brought to the front.
When the corresponding key is pressed and this program is already at the front, the window would be minimized. < -------------------------------------------- see here
When the corresponding key is pressed and the program isn't launched yet, it is spawned by running the program in the command property.

distefam commented 11 months ago

This would be the desired behavior for me as well.

adrienverge commented 11 months ago

Sorry for the late reply.

When the corresponding key is pressed and this program is already at the front, the window would be minimized. < -------------------------------------------- see here

OK, I tried it and it's nice.

Could you clean the commit? (remove all the commented code, let → const, code style and whitespaces, 2-space indentation, remove get_active_window() if global.display.focus_window should be used everywhere, etc.)

jixiuf commented 11 months ago

I don't use gnome any more ,you can just merge it and clean it by youself.