search

adrienverge / localstripe

A fake but stateful Stripe server that you can run locally, for testing purposes.
GNU General Public License v3.0
192 stars 59 forks source link

feat(usage): add usage records anf fix sub item error #195

Closed pandomic closed 3 years ago

pandomic commented 3 years ago
H--o-l commented 3 years ago

Hey @pandomic,

Thanks for opening a PR!

A few remarks, however.

There is a lot of commits in the branch you propose, and some look outdated. Maybe you can rebase and keep only the commits you want this PR to be about?

My second remark is that some of your commits seem to do two things at a time, please split commits per feature or resource or parameters, the level that makes the more sense, and write a commit message as is both simple and enough to understand your goal. Last things, commits like fix(linter): Fix linter errors which fix things of a previous commit of the same PR should be squashed in the previous commit.

Thanks in advance, cheers! Hoel

pandomic commented 3 years ago

@H--o-l thanks for your comments, we cleaned the history and opened a new PR, looking forward: https://github.com/adrienverge/localstripe/pull/197