search

adrienverge / localstripe

A fake but stateful Stripe server that you can run locally, for testing purposes.
GNU General Public License v3.0
192 stars 59 forks source link

Usage records and other fixes #197

Open pandomic opened 3 years ago

pandomic commented 3 years ago

Summary

H--o-l commented 3 years ago

Hey @pandomic!

About the commit fix(javascript): Be less pedantic about already modified DOM can you describe why you need it? What is your use case? What issue does it solve for you? Also the commit change two lines that I'm not sure are related. With an explanation inside the commit message, it would be easier for me to understand what you are doing.

About chore(gitignore): Add .venv and .idea to gitignore and chore(Dockerfile): Add Dockerfile , localstripe doesn't need that, it's specific to your environment, and we don't want to maintain it. Can you remove them?

About the last two commits, they look great! We will try to review them in-deep soon.

pandomic commented 3 years ago

Hi @H--o-l, I left only subscription items and usage records-related changes. Looking forward to getting them merged.

Going back to your question, js-fix was there because of the mounting issue we had with React but leaving it out of scope for now.

I hope in the future we will see a containerized version as well ;)

pandomic commented 3 years ago

Hi @H--o-l, thanks for the feedback, I added proposed changes and force-pushed them to the current branch