adrienverge / openfortivpn

Client for PPP+TLS VPN tunnel services
GNU General Public License v3.0
2.7k stars 320 forks source link

half-internet-routes: the default? #327

Closed DimitriPapadopoulos closed 6 years ago

DimitriPapadopoulos commented 6 years ago

I find half-internet-routes easier to understand and in a case I was interested in it worked better.

@adrienverge @mrbaseman Would you agree on making this option the default?

adrienverge commented 6 years ago

Unless @mrbaseman has a different opinion, I have no problem with this.

mrbaseman commented 6 years ago

It's fine with me. The half internet routes approach has a few (minor) disadvantages:

therefore we should keep the traditional behavior available, but I don't see any problem making half-internet-routes=1 the default while half-internet-routes=0 switches back to the traditional behavior.

DimitriPapadopoulos commented 6 years ago

Both arguments of @mrbaseman make sense. Perhaps it's better to leave things as is then.