search

adrienverge / openfortivpn

Client for PPP+TLS VPN tunnel services
GNU General Public License v3.0
2.72k stars 321 forks source link

refactoring of ipv4_add_nameservers_to_resolv_conf #548

Open mrbaseman opened 4 years ago

mrbaseman commented 4 years ago

ipv4_add_nameservers_to_resolv_conf would benefit from some refactoring, see https://github.com/adrienverge/openfortivpn/pull/547#issuecomment-591893613

DimitriPapadopoulos commented 4 years ago

Code Inspector suggests refactoring other long/complex functions. Might be of interest in some cases. On the other hand most issues raised by Code Inspector do not seem relevant to me.