search

adrienverge / yamllint

A linter for YAML files.
GNU General Public License v3.0
2.83k stars 269 forks source link

fix (#542): validate `ignore-from-file` in `validate_rule_conf` #591

Closed ndrwnaguib closed 9 months ago

ndrwnaguib commented 1 year ago

Fix #542. The ignore-from-file key wasn't validated in validate_rule_conf.

coveralls commented 1 year ago

Coverage Status

coverage: 99.397% (+0.001%) from 99.396% when pulling 36007a24e599f66d43fe60058619039d3e112418 on ndrwnaguib:fix/issues-542 into 1f79e62a98ce7884fe7794ec750955fbc1cead94 on adrienverge:master.

ndrwnaguib commented 10 months ago

@adrienverge I rebased onto master using GitHub's update branch button. But, I checked the commit history, I do not see any merge commits, would you like me to drop it and rebase interactively instead?--unless you are going to squash the commits.

adrienverge commented 9 months ago

Hello,

I allowed myself to force-push to your branch because 2 of my requests were not addressed.

Also the commit title referenced #524 which is unrelated. I amended that and reworded the commit for better understanding and maintenance.

Let's merge now.

ndrwnaguib commented 9 months ago

I allowed myself to force-push to your branch because 2 of my requests were not addressed.

That's alright. Sorry about missing them.

Also the commit title referenced #524 which is unrelated. I amended that and reworded the commit for better understanding and maintenance.

Thank you. I meant #542.