build: Replace flake8 with ruff

adrienverge / yamllint

A linter for YAML files.

GNU General Public License v3.0

2.79k stars 265 forks source link

build: Replace flake8 with ruff #629

Closed DimitriPapadopoulos closed 6 months ago

DimitriPapadopoulos commented 7 months ago

Enable isort (I) rules, in addition to the default set of rules.

Fixes #628.

Requires to be rebased on top of #627 to pass tests.

coveralls commented 7 months ago

coverage: 99.822%. remained the same when pulling 132276050de212eda397757c01cf1af3f8566325 on DimitriPapadopoulos:flake8_ruff into 1d65ab62cb9fd6bb29f1dd7b9aed7a4f371fc08c on adrienverge:master.

DimitriPapadopoulos commented 6 months ago

Perhaps I can find a ruff setting for that, ruff is more flexible than black. Let me have a look. But yes, I would recommend endorsing whatever ruff suggests and not thinking too much about it, as far as readability is not impaired.

DimitriPapadopoulos commented 6 months ago

I had a look at the isort settings, I believe lines-after-imports = 2 will do the trick. I'll give it a try.

DimitriPapadopoulos commented 6 months ago

Can you have a look? Now ruff adds a line where there was only 1 line. Is lines-after-imports = 2 really worth it?