Open Jayman2000 opened 10 months ago
I just noticed that one of the checks for this PR is failing. The coverage for yamllint/config.py
went down, but that’s just because the total number relevant lines went down. There’s only two lines that aren’t covered, but those same two lines aren’t covered in the master branch. Is there anything that I need to do here?
Is there anything that I need to do here?
At the moment, no. I'm sorry, please excuse the delay, this is a big change with much impact, I need a large time slot to review this, which I couldn't find yet.
This PR makes sure that yamllint never uses
open()
’s default encoding. Specifically, it uses the character encoding detection algorithm specified in chapter 5.2 of the YAML spec when reading both YAML files and files that are on theignore-from-file
list.There are two other PRs that are similar to this one. Here’s how this PR compares to those two:
ignore-from-file
list. Those two PRs only detects the encoding of files being linted.240 PR adds a dependency on
chardet
. This PR doesn’t add any dependencies.581 adds support for running tests on Windows. This PR doesn’t.
yamllint
package is simpler.test
package is much more complicated, but hopefully it tests things more thoroughly.Fixes #218. Fixes #238. Fixes #347. Closes #240. Closes #581.