Open jenstroeger opened 6 months ago
Hello and thanks for your clear and comprehensible message.
Unfortunately, no: we won't accept a PR that changes yamllint output for a specific debugging use-case.
However, you can try building your own customized yamllint and use it or GitHub CI (I guess it's possible somehow). You should also try to narrow down the problem, for instance by running yamllint directly (instead of make and pre-commit), and see if you find something.
Unfortunately, no: we won't accept a PR that changes yamllint output for a specific debugging use-case.
Hmm bummer; I’d argue it improved the error message in general, but ok.
Any idea about what might be going on here? I’m unable to reproduce this locally on Windows… so… 🤔
First of all, thank you for a great tool!
While playing with it, I came across an obscure issue running on Github’s Windows runner: see for example this failing run. Now here’s the puzzling problem… all YAML files in question use
\n
line-endings, for example the .yamllint.yaml file:By default,
yamllint
checks for UNIX-type line-endings (docs, src) which would be ok for these YAML files. Furthermore, YAML files are opened with their native line-endings preserved (docs): https://github.com/adrienverge/yamllint/blob/1d65ab62cb9fd6bb29f1dd7b9aed7a4f371fc08c/yamllint/cli.py#L222-L223 So by all means and purposes, that check should pass — but it doesn’t 🤔After poking through the code I can’t spot an obvious issue. I’m also unable to reproduce this on Windows because I’m unsure how the GIthub runner executes Python: native Windows or via WSL.
Maybe this issue is related to issue https://github.com/adrienverge/yamllint/issues/218 or https://github.com/adrienverge/yamllint/issues/347, although I don’t quite see the connection. To aid debugging, I’m tempted to expand the error message
to get more details. Would you accept a PR?