search

adrienverge / yamllint

A linter for YAML files.
GNU General Public License v3.0
2.9k stars 278 forks source link

build: requires setuptools-scm #639

Closed DimitriPapadopoulos closed 10 months ago

coveralls commented 10 months ago

Coverage Status

coverage: 99.822%. remained the same when pulling ced6bec16f7dcbe8286664e18518977041e6aaec on DimitriPapadopoulos:requires_setuptools-scm into fd8ddeef8b146e4312037edfe742ee9e06195f58 on adrienverge:master.

adrienverge commented 10 months ago

About the first commit build: format requires as in setuptools doc, the mentioned documentation shows various examples, including a majority of "one space on each side":

BazSpam == 1.1
pywin32 >= 1.0

Moreover the "one space on each side" style is consistent with the dependencies section. So I propose to drop this change.

About the second commit build: requires setuptools-scm, I'm pretty sure you are right to add it, but I (and potential reviewers of this PR) don't have the reason. Can you document why inside the commit message? (I see a note about setuptools-scm on https://setuptools.pypa.io/en/latest/userguide/dependency_management.html, but it's not explicit why it would apply to yamllint.)

DimitriPapadopoulos commented 10 months ago

I'll drop the first commit.

As for the second commit, I thought setuptools_scm is used by yamllint, but it is not. Maybe an effect of my mixing versions of pip/python?